Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH -next 2/3] xen: balloon: Replaced simple_strtoull() with kstrtoull() | Date | Thu, 27 May 2021 14:10:21 +0000 |
| |
From: Chen Huang > Sent: 26 May 2021 10:20 > > The simple_strtoull() function is deprecated in some situation, since > it does not check for the range overflow, use kstrtoull() instead. > ... > - target_bytes = simple_strtoull(buf, &endchar, 0) * 1024; > + ret = kstrtoull(buf, 0, &target_bytes); > + if (ret) > + return ret; > + target_bytes *= 1024;
I'd have thought it was more important to check *endchar than overflow. If you are worried about overflow you need a range check before the multiply.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |