lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: elants_i2c - Fix NULL dereference at probing
On Wed, 26 May 2021 22:19:51 +0200,
Dmitry Torokhov wrote:
>
> Hi Takashi,
>
> On Wed, May 26, 2021 at 09:43:01PM +0200, Takashi Iwai wrote:
> > The recent change in elants_i2c driver to support more chips
> > introduced a regression leading to Oops at probing. The driver reads
> > id->driver_data, but the id may be NULL depending on the device type
> > the driver gets bound.
> >
> > Add a NULL check and falls back to the default EKTH3500.
>
> Thank you for the patch. I think my preference would be to switch to
> device_get_match_data() and annotate the rest of the match tables with
> proper controller types.

OK, that sounds feasible. Shall I submit a revised patch?


Takashi

\
 
 \ /
  Last update: 2021-05-27 08:21    [W:0.272 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site