lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] regulator: fan53555: add back tcs4526
    On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
    > On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:

    > > +               reg = <0x1c>;
    > > +               vin-supply = <&vcc5v0_sys>;
    > > +               regulator-compatible = "fan53555-reg";

    > I can be wrong, but I think regulator-compatible is deprecated.

    Yes.

    > > +               regulator-ramp-delay = <1000>;
    > > +               fcs,suspend-voltage-selector = <1>;
    > > +               regulator-always-on;
    > > +               regulator-boot-on;

    > Just out of curiosity, is regulator-boot-on really needed for the GPU?

    It should only be used if it's not possible to read the state of
    the regulator enable from the hardware.

    Please delete unneeded context from mails when replying. Doing this
    makes it much easier to find your reply in the message, helping ensure
    it won't be missed by people scrolling through the irrelevant quoted
    material.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-05-27 15:07    [W:2.982 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site