lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] dt-bindings: connector: Replace BIT macro with generic bit ops
On Thu, May 27, 2021 at 08:10:29PM +0800, Kyle Tso wrote:
> BIT macro is not defined. Replace it with generic bit operations.
>
> Fixes: 630dce2810b9 ("dt-bindings: connector: Add SVDM VDO properties")
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
> Changes since v1:
> - re-word the commit message
>
> include/dt-bindings/usb/pd.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/dt-bindings/usb/pd.h b/include/dt-bindings/usb/pd.h
> index fef3ef65967f..cb70b4ceedde 100644
> --- a/include/dt-bindings/usb/pd.h
> +++ b/include/dt-bindings/usb/pd.h
> @@ -163,10 +163,10 @@
> #define UFP_VDO_VER1_2 2
>
> /* Device Capability */
> -#define DEV_USB2_CAPABLE BIT(0)
> -#define DEV_USB2_BILLBOARD BIT(1)
> -#define DEV_USB3_CAPABLE BIT(2)
> -#define DEV_USB4_CAPABLE BIT(3)
> +#define DEV_USB2_CAPABLE (1 << 0)
> +#define DEV_USB2_BILLBOARD (1 << 1)
> +#define DEV_USB3_CAPABLE (1 << 2)
> +#define DEV_USB4_CAPABLE (1 << 3)

Why not just include the proper .h file instead?

\
 
 \ /
  Last update: 2021-05-27 14:42    [W:0.066 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site