lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 0/5] Add devm helper for work-queue initialization
From
Date
Hi,

On 5/18/21 2:31 PM, Matti Vaittinen wrote:
> This series adds new devm_work_autocancel() helper.
>
> Many drivers which use work-queues must ensure the work is not queued when
> driver is detached. Often this is done by ensuring new work is not added and
> then calling cancel_work_sync() at remove(). In many cases this also requires
> cleanup at probe error path - which is easy to forget (or get wrong).
>
> Also the "by ensuring new work is not added" has a gotcha.
>
> It is not strange to see devm managed IRQs scheduling work.
> Mixing this with manual wq clean-up is hard to do correctly because the
> devm is likely to free the IRQ only after the remove() is ran. So manual
> wq cancellation and devm-based IRQ management do not mix well - there is
> a short(?) time-window after the wq clean-up when IRQs are still not
> freed and may schedule new work.
>
> When both WQs and IRQs are managed by devm things are likely to just
> work. WQs should be initialized before IRQs (when IRQs need to schedule
> work) and devm unwinds things in "FILO" order.
>
> This series implements wq cancellation on top of devm and replaces
> the obvious cases where only thing remove call-back in a driver does is
> cancelling the work. There might be other cases where we could switch
> more than just work cancellation to use managed version and thus get rid
> of remove or mixed (manual and devm) resource management.
>
> Changelog v2:
> - rebased on v5.13-rc2
> - split the extcon-max8997 change into two. First a simple,
> back-portable fix for omitting IRQ freeing at error path, second
> being the devm-simpification which does not need backporting.

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

As for merging this. Normally as the include/linux/devm-helpers.h
maintainer I would pick-up at least patch 1/5 and then provide an
immutable branch + pull-req; or just merge the entire series.

But since there are no other include/linux/devm-helpers.h changes
planned for 5.14 and since all the other patches are extcon changes,
I believe it would be best if the entire series would just be merged
through the extcon tree. Chanwoo / MyungJoo does that work for you ?

Regards,

Hans

>
> ---
>
> Matti Vaittinen (5):
> devm-helpers: Add resource managed version of work init
> extcon: extcon-max14577: Fix potential work-queue cancellation race
> extcon: extcon-max77693.c: Fix potential work-queue cancellation race
> extcon: extcon-max8997: Fix IRQ freeing at error path
> extcon: extcon-max8997: Simplify driver using devm
>
> drivers/extcon/extcon-max14577.c | 16 ++++--------
> drivers/extcon/extcon-max77693.c | 17 ++++--------
> drivers/extcon/extcon-max8997.c | 45 +++++++++++---------------------
> include/linux/devm-helpers.h | 25 ++++++++++++++++++
> 4 files changed, 50 insertions(+), 53 deletions(-)
>
>
> base-commit: d07f6ca923ea0927a1024dfccafc5b53b61cfecc
>

\
 
 \ /
  Last update: 2021-05-27 13:08    [W:0.076 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site