Messages in this thread | | | Date | Thu, 27 May 2021 12:09:21 +0300 | From | Tony Lindgren <> | Subject | Re: [PATCH v3] ARM: dts: dra7: Fix duplicate USB4 target module node |
| |
* Grygorii Strashko <grygorii.strashko@ti.com> [210527 09:03]: > On 27/05/2021 08:48, Tony Lindgren wrote: > > But let's keep the target-module@140000 here as it puts it in the right > > location rather than directly on the ocp. Let's mark it with > > status = "disabled" in dra7-l4.dtsi, and add a comment noting it's only > > available on dra74x. So similar to what you had in your v1 patch, except > > disabled. > > My preference would be not to mix SoC variant specific modules in common module, > and fix dra74x instead by placing usb4 node in proper place: > > &l4_per3 { /* 0x48800000 */ > segment@0 { > -->
Yeah that's even better, and leaves out status = "disabled". Sounds good to me.
Regards,
Tony
| |