lkml.org 
[lkml]   [2021]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH net-next v3 2/2] bonding/balance-alb: put all slaves into promisc
Date
Unlike most other modes with a primary interface, ALB mode bonding can
receive on all slaves. That includes traffic destined for a non-local MAC
behind a bridge on top of the bond. In such setups, the bridge driver puts
all ports (including the bond) into promiscuous mode, but we're not
propagating that change down to the non-primary slaves in ALB mode. As a
result, incoming traffic to those interfaces gets dropped. Since ALB can
receive on all slaves, all slaves should get promiscuity changes
propagated to them.

Cc: Jay Vosburgh <j.vosburgh@gmail.com>
Cc: Veaceslav Falico <vfalico@gmail.com>
Cc: Andy Gospodarek <andy@greyhouse.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Thomas Davis <tadavis@lbl.gov>
Cc: netdev@vger.kernel.org
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
drivers/net/bonding/bond_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 666051f91d70..3933219ae773 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -647,9 +647,10 @@ static int bond_check_dev_link(struct bonding *bond,
static int bond_set_promiscuity(struct bonding *bond, int inc)
{
struct list_head *iter;
- int err = 0;
+ int mode, err = 0;

- if (bond_uses_primary(bond)) {
+ mode = BOND_MODE(bond);
+ if (mode == BOND_MODE_ACTIVEBACKUP || mode == BOND_MODE_TLB) {
struct slave *curr_active = rtnl_dereference(bond->curr_active_slave);

if (curr_active)
--
2.30.2
\
 
 \ /
  Last update: 2021-05-27 22:02    [W:0.086 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site