lkml.org 
[lkml]   [2021]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 00/33] locking/atomic: convert all architectures to ARCH_ATOMIC
> On Tue, May 25, 2021 at 03:01:59PM +0100, Mark Rutland wrote:
> > Note: I've generated the patches with:
> >
> > git format-patch -C -M -D
> >
> > ... so the preimage of include/linux/atomic-fallback.h is not included
> > in the diff when it is deleted.
> ...
> Junio; can we get something like the below sorted?

Funny, I recently looked at "git format-patch --help" and read that "-D"
is explicitly described as "The resulting patch is not meant to be applied
with patch or git apply; this is solely for people who want to just
concentrate on reviewing the text after the change."

So, no, I think it is anti-social to send such a patch generated with -D
unless it is purely for discussion. The side that generates the patch
should be told to drop "-D" when running the format-patch command,
or perhaps format-patch should be taught to error out when "-D" is
given, perhaps?

\
 
 \ /
  Last update: 2021-05-26 14:30    [W:0.497 / U:1.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site