Messages in this thread | | | Subject | Re: [PATCH] kbuild: quote OBJCOPY var to avoid a pahole call break the build | From | Javier Martinez Canillas <> | Date | Wed, 26 May 2021 23:49:58 +0200 |
| |
On 5/26/21 11:02 PM, Andrii Nakryiko wrote:
[snip]
>> >> BTW, I see similar code in scripts/link-vmlinux.sh too. >> >> LLVM_OBJCOPY=${OBJCOPY} ${PAHOLE} -J ${extra_paholeopt} ${1} >> >> Is it OK to leave it unquoted? > > You are right, link-vmlinux.sh should be updated accordingly. >
Good catch. I'll include this in v2 as well.
> Javier, can you please send v2 and cc bpf@vger.kernel.org? Thanks! >
Sure, thanks!
Best regards, -- Javier Martinez Canillas Software Engineer New Platform Technologies Enablement team RHEL Engineering
| |