Messages in this thread | | | Date | Tue, 25 May 2021 16:46:31 +0000 | From | Sean Christopherson <> | Subject | Re: [kbuild-all] Re: [PATCH] kvm: fix boolreturn.cocci warnings |
| |
On Tue, May 25, 2021, Rong Chen wrote: > > > On 5/25/21 3:11 PM, Peter Zijlstra wrote: > > On Tue, May 25, 2021 at 01:59:40PM +0800, kernel test robot wrote: > > > From: kernel test robot <lkp@intel.com> > > > > > > arch/arm64/kvm/mmu.c:1203:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1173:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1216:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool > > > arch/arm64/kvm/mmu.c:1159:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool > > > > > > Return statements in functions returning bool should use > > > true/false instead of 1/0. > > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Per 2b076054e524 ("remove boolinit.cocci"), I have a very dim view of > > this sort of thing. > > Hi Peterz, > > Sorry for the noise, we'll disable the check. > > > > > > Fixes: 63b3f96e1a98 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT") > > *how* ?!? > > The bot is stupid
LOL. FWIW, it's not _that_ stupid, or maybe it's the broken clock adage... The proper fix is sitting in the KVM tree, it should soon make its way to Linus.
fcb8283920b1 ("KVM: arm64: Fix boolreturn.cocci warnings")
| |