lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: gpio-ath79: remove platform_set_drvdata() + cleanup probe
On Mon, May 17, 2021 at 1:37 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-ath79.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index 678ddd375891..9b780dc5d390 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -234,7 +234,6 @@ static int ath79_gpio_probe(struct platform_device *pdev)
> ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
> if (!ctrl)
> return -ENOMEM;
> - platform_set_drvdata(pdev, ctrl);
>
> if (np) {
> err = of_property_read_u32(np, "ngpios", &ath79_gpio_count);
> @@ -290,13 +289,7 @@ static int ath79_gpio_probe(struct platform_device *pdev)
> girq->handler = handle_simple_irq;
> }
>
> - err = devm_gpiochip_add_data(dev, &ctrl->gc, ctrl);
> - if (err) {
> - dev_err(dev,
> - "cannot add AR71xx GPIO chip, error=%d", err);
> - return err;
> - }
> - return 0;
> + return devm_gpiochip_add_data(dev, &ctrl->gc, ctrl);
> }
>
> static struct platform_driver ath79_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart

\
 
 \ /
  Last update: 2021-05-25 16:35    [W:0.057 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site