lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpio: gpio-tps65910: remove platform_set_drvdata() + cleanup probe
On Fri, May 21, 2021 at 8:17 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-tps65910.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
> index 0c0b445c75c0..7fa8c841081f 100644
> --- a/drivers/gpio/gpio-tps65910.c
> +++ b/drivers/gpio/gpio-tps65910.c
> @@ -165,16 +165,8 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
> }
>
> skip_init:
> - ret = devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
> - tps65910_gpio);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, tps65910_gpio);
> -
> - return ret;
> + return devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
> + tps65910_gpio);
> }
>
> static struct platform_driver tps65910_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart

\
 
 \ /
  Last update: 2021-05-25 16:35    [W:0.224 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site