lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/14] Clean W=1 build warnings for mm/
On Tue, May 25, 2021 at 01:48:26PM +0200, Vlastimil Babka wrote:
> On 5/20/21 10:47 AM, Mel Gorman wrote:
> > This is a janitorial only. During development of a tool to catch build
> > warnings early to avoid tripping the Intel lkp-robot, I noticed that mm/
> > is not clean for W=1. This is generally harmless but there is no harm in
> > cleaning it up. It disrupts git blame a little but on relatively obvious
> > lines that are unlikely to be git blame targets.
> >
> > include/asm-generic/early_ioremap.h | 9 +++++++++
> > include/linux/mmzone.h | 5 ++++-
> > include/linux/swap.h | 6 +++++-
> > mm/internal.h | 3 +--
> > mm/mapping_dirty_helpers.c | 2 +-
> > mm/memcontrol.c | 2 +-
> > mm/memory_hotplug.c | 6 +++---
> > mm/mmap_lock.c | 2 ++
> > mm/page_alloc.c | 2 +-
> > mm/vmalloc.c | 3 +++
> > mm/vmscan.c | 2 +-
> > mm/z3fold.c | 2 ++
> > mm/zbud.c | 2 ++
> > 13 files changed, 35 insertions(+), 11 deletions(-)
>
> Thanks, looks good.
>
> patch 3/14 subject looks like it should read just "mm/page_alloc: Make
> should_fail_alloc_page a static function"
>

Yes it should. Andrew, do you mind fixing it directly instead of
resending the entire series?

> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>

Thanks!

--
Mel Gorman
SUSE Labs

\
 
 \ /
  Last update: 2021-05-25 16:25    [W:0.552 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site