| Date | Tue, 25 May 2021 14:04:36 +0100 | From | Mel Gorman <> | Subject | Re: [RFC 10/26] mm, slub: do initial checks in ___slab_alloc() with irqs enabled |
| |
On Tue, May 25, 2021 at 01:39:30AM +0200, Vlastimil Babka wrote: > As another step of shortening irq disabled sections in ___slab_alloc(), don't > disable irqs until doing initial checks if there is a cached percpu slab and > it's suitable for our allocation. > > Now we have to recheck c->page after actually disabling irqs as an allocation > in irq might have replaced it. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Minor nit only -- consider adding a comment at the new_slab label that IRQs must be disabled already.
Acked-by: Mel Gorman <mgorman@techsingularity.net>
-- Mel Gorman SUSE Labs
|