Messages in this thread | | | Date | Tue, 25 May 2021 15:01:59 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 1/2] net: phy: fix yt8511 clang uninitialized variable warning |
| |
On Tue, May 25, 2021 at 08:26:14AM -0400, Peter Geis wrote: > clang doesn't preinitialize variables. If phy_select_page failed and > returned an error, phy_restore_page would be called with `ret` being > uninitialized. > Even though phy_restore_page won't use `ret` in this scenario, > initialize `ret` to silence the warning. > > Fixes: b1b41c047f73 ("net: phy: add driver for Motorcomm yt8511 phy") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Peter Geis <pgwipeout@gmail.com> > --- > drivers/net/phy/motorcomm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c > index 796b68f4b499..5795f446c528 100644 > --- a/drivers/net/phy/motorcomm.c > +++ b/drivers/net/phy/motorcomm.c > @@ -51,7 +51,7 @@ static int yt8511_write_page(struct phy_device *phydev, int page) > static int yt8511_config_init(struct phy_device *phydev) > { > unsigned int ge, fe; > - int ret, oldpage; > + int oldpage, ret = 0;
Please keep to reverse Christmas tree.
With that fixed:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |