lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] perf arm-spe: Remove redundant checking for "full_auxtrace"
From
Date


On 19/05/2021 07:15, Leo Yan wrote:
> The option "opts->full_auxtrace" is checked at the earlier place, if it
> is false the function will directly bail out. So remove the redundant
> checking for "opts->full_auxtrace".
>
> Suggested-by: James Clark <james.clark@arm.com>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/arch/arm64/util/arm-spe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/util/arm-spe.c
> index bacdf366040d..a4420d4df503 100644
> --- a/tools/perf/arch/arm64/util/arm-spe.c
> +++ b/tools/perf/arch/arm64/util/arm-spe.c
> @@ -116,7 +116,7 @@ static int arm_spe_recording_options(struct auxtrace_record *itr,
> return 0;
>
> /* We are in full trace mode but '-m,xyz' wasn't specified */
> - if (opts->full_auxtrace && !opts->auxtrace_mmap_pages) {
> + if (!opts->auxtrace_mmap_pages) {
> if (privileged) {
> opts->auxtrace_mmap_pages = MiB(4) / page_size;
> } else {
>

Reviewed-by: James Clark <james.clark@arm.com>

Thanks
James

\
 
 \ /
  Last update: 2021-05-25 14:04    [W:0.048 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site