Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 25 May 2021 15:03:15 +0300 | Subject | Re: [PATCH] lib/math/rational.c: Fix divide by zero |
| |
On Tue, May 25, 2021 at 12:21 PM Trent Piepho <tpiepho@gmail.com> wrote: > On Tue, May 25, 2021 at 2:02 AM Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > > > On Mon, May 24, 2021 at 01:17:48PM -0700, Trent Piepho wrote: > > > On Mon, May 24, 2021 at 3:51 AM Andy Shevchenko > > > <andriy.shevchenko@intel.com> wrote: > > > > On Sat, May 22, 2021 at 05:18:06PM -0700, Trent Piepho wrote: > > > > > > > > This misses the test cases (*). Please, develop them with Daniel. > > > > > > > > *) We usually don't accept changes in the generic libraries without test cases. > > > > > > > > Fixes tag? > > > > > > Is there a bug report on a tracker? I just got the email from Yigua. > > > > Fixes tag refers to the existing commit that brought the bug. > > Also you may need to add Reported-by tag since Yigua reported it. > > I did add a Reported-by tag.
Oh, I haven't seen it in the context left, but yes, I see it in the original mail, thanks!
> Wasn't clear to me fixing a specific > commit was entirely appropriate since not handling out of range values > correctly has been there all along.
Daniel proposed one, wouldn't it be good enough?
-- With Best Regards, Andy Shevchenko
| |