Messages in this thread | | | Date | Tue, 25 May 2021 08:44:50 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: syscon: Fix leak of syscon name |
| |
On Tue, 25 May 2021, Ansuel Smith wrote:
> regmap_init_mmio duplicate the name and never free the provided name in > the sysconf_config. Always free the name instead of freeing only on > error to fix error from kmemleak generated by any syscon user. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > drivers/mfd/syscon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Which repo have you authored this against?
I believe this is already fixed in -next.
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c > index c6f139b2e0c0..765c0210cb52 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk) > syscon_config.max_register = resource_size(&res) - reg_io_width; > > regmap = regmap_init_mmio(NULL, base, &syscon_config); > + kfree(syscon_config.name); > if (IS_ERR(regmap)) { > pr_err("regmap init failed\n"); > ret = PTR_ERR(regmap); > @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk) > regmap_exit(regmap); > err_regmap: > iounmap(base); > - kfree(syscon_config.name); > err_map: > kfree(syscon); > return ERR_PTR(ret);
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |