lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v7 05/12] virtio_scsi: Add validation for residual bytes from response
    From
    Date

    在 2021/5/17 下午5:55, Xie Yongji 写道:
    > This ensures that the residual bytes in response (might come
    > from an untrusted device) will not exceed the data buffer length.
    >
    > Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
    > ---
    > drivers/scsi/virtio_scsi.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
    > index efcaf0674c8d..ad7d8cecec32 100644
    > --- a/drivers/scsi/virtio_scsi.c
    > +++ b/drivers/scsi/virtio_scsi.c
    > @@ -97,7 +97,7 @@ static inline struct Scsi_Host *virtio_scsi_host(struct virtio_device *vdev)
    > static void virtscsi_compute_resid(struct scsi_cmnd *sc, u32 resid)
    > {
    > if (resid)
    > - scsi_set_resid(sc, resid);
    > + scsi_set_resid(sc, min(resid, scsi_bufflen(sc)));
    > }
    >
    > /*


    Acked-by: Jason Wang <jasowang@redhat.com>


    \
     
     \ /
      Last update: 2021-05-26 04:42    [W:3.637 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site