Messages in this thread | | | Subject | Re: [PATCH v2 1/3] pwm: mtk_disp: clear the clock operations | From | Jitao Shi <> | Date | Wed, 26 May 2021 09:54:03 +0800 |
| |
On Mon, 2021-02-22 at 22:29 +0800, Thierry Reding wrote: > On Sat, Jan 30, 2021 at 10:12:24PM +0800, Jitao Shi wrote: > > Remove the clk_prepare from mtk_disp_pwm_probe. > > Remove the clk_unprepare from mtk_disp_pwm_remove. > > > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > > --- > > drivers/pwm/pwm-mtk-disp.c | 23 ++--------------------- > > 1 file changed, 2 insertions(+), 21 deletions(-) > > It's not clear *why* you're doing this change. It's already obvious from > the changes in this patch that you're removing the calls to > clk_prepare() and clk_unprepare(), so instead of duplicating that > information in the commit message, take this opportunity to describe why > this change is needed. Without any further context, this would seem to > just break operation of this chip because now these clocks are never > enabled in the first place. > > Thierry
Thanks for your review.
I'll update the commit message next version.
The original issue is the clocks doesn't be disabled when system enter standby.
Then I adjust the the clock sequence. and Uwe subject convert thelegacy APIs of .apply().
| |