Messages in this thread | | | Date | Tue, 25 May 2021 20:58:03 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.10 29/62] Revert "ASoC: rt5645: fix a NULL pointer dereference" |
| |
On Tue, May 25, 2021 at 11:00:33PM +0100, Mark Brown wrote: >On Mon, May 24, 2021 at 10:47:10AM -0400, Sasha Levin wrote: > >> Lots of things seem to be still allocated here and must be properly >> cleaned up if an error happens here. > >That's not true, the core already has cleanup for everything else >(as the followup patch in your series identified, though it was a >bit confused as to how). > >> RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s), >> GFP_KERNEL); >> >> - if (!rt5645->eq_param) >> - return -ENOMEM; >> - > >Without the followup patch (which I don't think is suitable for >stable) this will just remove error checking. It's not likely to >happen and hence make a difference but on the other hand it >introduces a problem, especially when backported in isolation.
I'll drop this and the follow up patch, thanks.
-- Thanks, Sasha
| |