lkml.org 
[lkml]   [2021]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL 5.10 29/62] Revert "ASoC: rt5645: fix a NULL pointer dereference"
    On Tue, May 25, 2021 at 11:00:33PM +0100, Mark Brown wrote:
    >On Mon, May 24, 2021 at 10:47:10AM -0400, Sasha Levin wrote:
    >
    >> Lots of things seem to be still allocated here and must be properly
    >> cleaned up if an error happens here.
    >
    >That's not true, the core already has cleanup for everything else
    >(as the followup patch in your series identified, though it was a
    >bit confused as to how).
    >
    >> RT5645_HWEQ_NUM, sizeof(struct rt5645_eq_param_s),
    >> GFP_KERNEL);
    >>
    >> - if (!rt5645->eq_param)
    >> - return -ENOMEM;
    >> -
    >
    >Without the followup patch (which I don't think is suitable for
    >stable) this will just remove error checking. It's not likely to
    >happen and hence make a difference but on the other hand it
    >introduces a problem, especially when backported in isolation.

    I'll drop this and the follow up patch, thanks.

    --
    Thanks,
    Sasha

    \
     
     \ /
      Last update: 2021-05-26 02:58    [W:3.106 / U:0.636 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site