Messages in this thread | | | Date | Tue, 25 May 2021 09:11:04 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] kvm: fix boolreturn.cocci warnings |
| |
On Tue, May 25, 2021 at 01:59:40PM +0800, kernel test robot wrote: > From: kernel test robot <lkp@intel.com> > > arch/arm64/kvm/mmu.c:1203:9-10: WARNING: return of 0/1 in function 'kvm_age_gfn' with return type bool > arch/arm64/kvm/mmu.c:1173:9-10: WARNING: return of 0/1 in function 'kvm_set_spte_gfn' with return type bool > arch/arm64/kvm/mmu.c:1216:9-10: WARNING: return of 0/1 in function 'kvm_test_age_gfn' with return type bool > arch/arm64/kvm/mmu.c:1159:9-10: WARNING: return of 0/1 in function 'kvm_unmap_gfn_range' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci
Per 2b076054e524 ("remove boolinit.cocci"), I have a very dim view of this sort of thing.
> Fixes: 63b3f96e1a98 ("kvm: Select SCHED_INFO instead of TASK_DELAY_ACCT")
*how* ?!?
| |