Messages in this thread Patch in this message | | | From | "Vaittinen, Matti" <> | Subject | Re: [PATCH] regulator: bd71815: add select to fix build | Date | Mon, 24 May 2021 05:30:56 +0000 |
| |
On Sat, 2021-05-22 at 17:14 -0700, Randy Dunlap wrote: > Mend the Kconfig for REGULATOR_BD71815 to prevent build errors: > > riscv32-linux-ld: drivers/regulator/bd71815-regulator.o: in function > `.L0 ': > regulator.c:289: undefined reference to > `rohm_regulator_set_dvs_levels' > riscv32-linux-ld: drivers/regulator/bd71815-regulator.c:370: > undefined reference to `rohm_regulator_set_dvs_levels' > > Fixes: 1aad39001e85 ("regulator: Support ROHM BD71815 regulators") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > --- Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Thank you (again) for fixing this Randy. I am quite sure this is not the first time I see this patch. As far as I remember few fixes were sent during last development cycle by Randy and Arnd - but I think they were not merged because commits they fixed were not yet in regulator tree.
I could go through those and resend them if they are missing - but is there a way to do that while giving the credit to original authors?
> drivers/regulator/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210521.orig/drivers/regulator/Kconfig > +++ linux-next-20210521/drivers/regulator/Kconfig > @@ -207,6 +207,7 @@ config REGULATOR_BD70528 > config REGULATOR_BD71815 > tristate "ROHM BD71815 Power Regulator" > depends on MFD_ROHM_BD71828 > + select REGULATOR_ROHM > help > This driver supports voltage regulators on ROHM BD71815 PMIC. > This will enable support for the software controllable buck
| |