lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page()
On Sun 23-05-21 17:02:58, YueHaibing wrote:
> Condition !A || A && B is equivalent to !A || B.
>
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Fair enough. Thanks for the patch. Added to my tree.

Honza

> ---
> fs/reiserfs/inode.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 780bb90c1804..f49b72ccac4c 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -2584,9 +2584,7 @@ static int reiserfs_write_full_page(struct page *page,
> clear_buffer_dirty(bh);
> set_buffer_uptodate(bh);
> } else if ((checked || buffer_dirty(bh)) &&
> - (!buffer_mapped(bh) || (buffer_mapped(bh)
> - && bh->b_blocknr ==
> - 0))) {
> + (!buffer_mapped(bh) || bh->b_blocknr == 0)) {
> /*
> * not mapped yet, or it points to a direct item, search
> * the btree for the mapping info, and log any direct
> --
> 2.20.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2021-05-24 11:03    [W:1.025 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site