lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 13/14] soc/tegra: pmc: Add core power domain
    From
    Date
    24.05.2021 20:04, Ulf Hansson пишет:
    >> +static void tegra_pmc_sync_state(struct device *dev)
    >> +{
    >> + int err;
    >> +
    >> + pmc->core_domain_state_synced = true;
    >> +
    >> + /* this is a no-op if core regulator isn't used */
    >> + mutex_lock(&pmc->powergates_lock);
    >> + err = dev_pm_opp_sync_regulators(dev);
    >> + mutex_unlock(&pmc->powergates_lock);
    >> +
    >> + if (err)
    >> + dev_err(dev, "failed to sync regulators: %d\n", err);
    >> +}
    >> +
    > Nitpick.
    >
    > Would you mind splitting the "sync_state" thingy out into a separate
    > patch on top of $subject patch?
    >
    > I think it would be nice, especially since it shares a function via
    > include/soc/tegra/common.h - that would make it clear to what part
    > that belongs to.
    >

    I'll split it in v3. Thank you for the review.

    \
     
     \ /
      Last update: 2021-05-24 22:25    [W:4.702 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site