Messages in this thread | | | From | Alex Deucher <> | Date | Mon, 24 May 2021 14:48:55 -0400 | Subject | Re: [PATCH] drm/amdgpu: remove unreachable code |
| |
Applied. Thanks!
Alex
On Mon, May 24, 2021 at 6:47 AM Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > In the function amdgpu_uvd_cs_msg(), every branch in the switch > statement will have a return, so the code below the switch statement > will not be executed. > > Eliminate the follow smatch warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:845 amdgpu_uvd_cs_msg() warn: > ignoring unreachable code. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > index 82f0542..375b346 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c > @@ -842,8 +842,6 @@ static int amdgpu_uvd_cs_msg(struct amdgpu_uvd_cs_ctx *ctx, > DRM_ERROR("Illegal UVD message type (%d)!\n", msg_type); > return -EINVAL; > } > - BUG(); > - return -EINVAL; > } > > /** > -- > 1.8.3.1 >
| |