Messages in this thread | | | Date | Mon, 24 May 2021 19:19:07 +0300 | From | Pavel Skripkin <> | Subject | Re: [PATCH] This patch fixes the warning generated due to use of symbolic |
| |
On Mon, 24 May 2021 21:27:06 +0530 Aviral Gupta <shiv14112001@gmail.com> wrote:
> It's better to use octal permissons instead of symbolic ones because > peoples are more familiar with octal permissons. > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > + md->force_ro.attr.mode = S_IRUGO | S_IWUSR; > > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider > using octal permissions '0444'. > + mode = S_IRUGO; > > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. > Consider using octal permissions '0644'. > + mode = S_IRUGO | S_IWUSR; > > WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider > using octal permissions '0400'. > + debugfs_create_file("ext_csd", S_IRUSR, > root, card, > > Signed-off-by: Aviral Gupta <shiv14112001@gmail.com> > --- > drivers/mmc/core/block.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
Hi, Aviral!
I guess, you missed my and Greg's mails last time...
Anyway, subject line is strange, it should be smth like "mmc: core: fix symbolic permissions".
Please, refer to https://www.kernel.org/doc/html/latest/process/submitting-patches.html.
With regards, Pavel Skripkin
| |