lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.12 063/127] platform/x86: ideapad-laptop: fix method name typo
    Date
    From: Barnabás Pőcze <pobrn@protonmail.com>

    commit b09aaa3f2c0edeeed670cd29961a0e35bddc78cf upstream.

    "smbc" should be "sbmc". `eval_smbc()` incorrectly called
    the SMBC ACPI method instead of SBMC. This resulted in
    partial loss of functionality. Rectify that by calling
    the correct ACPI method (SBMC), and also rename
    methods and constants.

    BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212985
    Fixes: 0b765671cb80 ("platform/x86: ideapad-laptop: group and separate (un)related constants into enums")
    Fixes: ff36b0d953dc ("platform/x86: ideapad-laptop: rework and create new ACPI helpers")
    Cc: stable@vger.kernel.org # 5.12
    Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
    Link: https://lore.kernel.org/r/20210507235333.286505-1-pobrn@protonmail.com
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/platform/x86/ideapad-laptop.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    --- a/drivers/platform/x86/ideapad-laptop.c
    +++ b/drivers/platform/x86/ideapad-laptop.c
    @@ -57,8 +57,8 @@ enum {
    };

    enum {
    - SMBC_CONSERVATION_ON = 3,
    - SMBC_CONSERVATION_OFF = 5,
    + SBMC_CONSERVATION_ON = 3,
    + SBMC_CONSERVATION_OFF = 5,
    };

    enum {
    @@ -182,9 +182,9 @@ static int eval_gbmd(acpi_handle handle,
    return eval_int(handle, "GBMD", res);
    }

    -static int exec_smbc(acpi_handle handle, unsigned long arg)
    +static int exec_sbmc(acpi_handle handle, unsigned long arg)
    {
    - return exec_simple_method(handle, "SMBC", arg);
    + return exec_simple_method(handle, "SBMC", arg);
    }

    static int eval_hals(acpi_handle handle, unsigned long *res)
    @@ -477,7 +477,7 @@ static ssize_t conservation_mode_store(s
    if (err)
    return err;

    - err = exec_smbc(priv->adev->handle, state ? SMBC_CONSERVATION_ON : SMBC_CONSERVATION_OFF);
    + err = exec_sbmc(priv->adev->handle, state ? SBMC_CONSERVATION_ON : SBMC_CONSERVATION_OFF);
    if (err)
    return err;


    \
     
     \ /
      Last update: 2021-05-24 18:07    [W:4.059 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site