lkml.org 
[lkml]   [2021]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 072/104] kcsan: Fix debugfs initcall return type
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 976aac5f882989e4f6c1b3a7224819bf0e801c6a upstream.

    clang with CONFIG_LTO_CLANG points out that an initcall function should
    return an 'int' due to the changes made to the initcall macros in commit
    3578ad11f3fb ("init: lto: fix PREL32 relocations"):

    kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int'
    late_initcall(kcsan_debugfs_init);
    ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
    include/linux/init.h:292:46: note: expanded from macro 'late_initcall'
    #define late_initcall(fn) __define_initcall(fn, 7)

    Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init")
    Cc: stable <stable@vger.kernel.org>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Reviewed-by: Marco Elver <elver@google.com>
    Reviewed-by: Nathan Chancellor <nathan@kernel.org>
    Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    kernel/kcsan/debugfs.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/kernel/kcsan/debugfs.c
    +++ b/kernel/kcsan/debugfs.c
    @@ -261,9 +261,10 @@ static const struct file_operations debu
    .release = single_release
    };

    -static void __init kcsan_debugfs_init(void)
    +static int __init kcsan_debugfs_init(void)
    {
    debugfs_create_file("kcsan", 0644, NULL, NULL, &debugfs_ops);
    + return 0;
    }

    late_initcall(kcsan_debugfs_init);

    \
     
     \ /
      Last update: 2021-05-24 18:00    [W:5.224 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site