Messages in this thread |  | | Date | Sun, 23 May 2021 13:14:39 +0800 | From | kernel test robot <> | Subject | Re: [PATCH net-next] ehea: Use DEVICE_ATTR_*() macro |
| |
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/0day-ci/linux/commits/YueHaibing/ehea-Use-DEVICE_ATTR_-macro/20210523-111702 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git f5120f5998803a973b1d432ed2aa7e592527aa46 config: powerpc-allmodconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7402089765bd60dcd72cad433fd318058e06d514 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review YueHaibing/ehea-Use-DEVICE_ATTR_-macro/20210523-111702 git checkout 7402089765bd60dcd72cad433fd318058e06d514 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kobject.h:20, from include/linux/energy_model.h:7, from include/linux/device.h:16, from drivers/net/ethernet/ibm/ehea/ehea_main.c:17: >> drivers/net/ethernet/ibm/ehea/ehea_main.c:3206:23: error: 'probe_port_store' undeclared here (not in a function); did you mean 'probe_port_show'? 3206 | static DEVICE_ATTR_WO(probe_port); | ^~~~~~~~~~ include/linux/sysfs.h:135:11: note: in definition of macro '__ATTR_WO' 135 | .store = _name##_store, \ | ^~~~~ drivers/net/ethernet/ibm/ehea/ehea_main.c:3206:8: note: in expansion of macro 'DEVICE_ATTR_WO' 3206 | static DEVICE_ATTR_WO(probe_port); | ^~~~~~~~~~~~~~ drivers/net/ethernet/ibm/ehea/ehea_main.c:3116:16: warning: 'probe_port_show' defined but not used [-Wunused-function] 3116 | static ssize_t probe_port_show(struct device *dev, | ^~~~~~~~~~~~~~~
vim +3206 drivers/net/ethernet/ibm/ehea/ehea_main.c
3205 > 3206 static DEVICE_ATTR_WO(probe_port); 3207 static DEVICE_ATTR_WO(remove_port); 3208
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] |  |