Messages in this thread Patch in this message |  | | From | nizamhaider786@gmail ... | Subject | [PATCH 1/2] char: pcmcia: scr24x_cs: Fix failure handling Handled failure cases of pcmcia_enable_device() and device_create() | Date | Sun, 23 May 2021 20:41:10 +0530 |
| |
From: Nijam Haider <nizamhaider786@gmail.com>
Signed-off-by: Nijam Haider <nizamhaider786@gmail.com> --- drivers/char/pcmcia/scr24x_cs.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c index 47feb39..cad1990 100644 --- a/drivers/char/pcmcia/scr24x_cs.c +++ b/drivers/char/pcmcia/scr24x_cs.c @@ -233,6 +233,7 @@ static int scr24x_probe(struct pcmcia_device *link) { struct scr24x_dev *dev; int ret; + struct device *dev_ret; dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (!dev) @@ -272,12 +273,20 @@ static int scr24x_probe(struct pcmcia_device *link) ret = pcmcia_enable_device(link); if (ret < 0) { + cdev_del(&dev->c_dev); pcmcia_disable_device(link); goto err; } - device_create(scr24x_class, NULL, MKDEV(MAJOR(scr24x_devt), dev->devno), + dev_ret = device_create(scr24x_class, NULL, MKDEV(MAJOR(scr24x_devt), dev->devno), NULL, "scr24x%d", dev->devno); + if (IS_ERR(dev_ret)) { + printk(KERN_ERR "device_create failed for %d\n", + dev->devno); + cdev_del(&dev->c_dev); + pcmcia_disable_device(link); + goto err; + } dev_info(&link->dev, "SCR24x Chip Card Interface\n"); return 0; -- 2.7.4
|  |