Messages in this thread |  | | Subject | Re: [PATCH 0/4] clk: mvebu: Fix some error handling paths + do some clean-up | From | Marion & Christophe JAILLET <> | Date | Sat, 22 May 2021 09:17:07 +0200 |
| |
Le 22/05/2021 à 08:51, Christophe JAILLET a écrit : > This serie fixes some (unlikely) error handlings paths. > > The 4th patch is completely speculative. When I compile-tested the changes, > I had to remove this line in order for it to compile. > As it works fine (at least for me) without it, I wonder if it is needed at all. > > > Also, I wonder if the drivers in drivers/clk/mvebu are used by anyone. > In order to compile-test the changes, I also had to change the 'bool' in Kconfig > by 'bool "blah"'. Without this change, it was not possible to set > CONFIG_MVEBU_CLK_CPU required by Makefile. > > I don't know if I did something wrong, if it is an issue only on my environment > or if something got broken at some time in the build chain but it looks > spurious. > > If I'm right and that these drivers never compile and no-one noticed it, > maybe removing them is better than fixing some unlikely issues and style. > If these drivers should stay, Kconfig may need some love from someone. > > Christophe JAILLET (4): > clk: mvebu: Fix a memory leak in an error handling path > clk: mvebu: Fix a another memory leak in an error handling path > clk: mvebu: Fix a checkpatch warning > clk: mvebu: Remove an unneeded include > > drivers/clk/mvebu/clk-cpu.c | 22 +++++++++++++--------- > 1 file changed, 13 insertions(+), 9 deletions(-)
NAK, wrong cover letter sent
Sorry for the noise.
CJ
|  |