Messages in this thread |  | | Subject | Re: [PATCH] LOCKDEP: use depends on LOCKDEP_SUPPORT instead of $ARCH list | From | Randy Dunlap <> | Date | Sat, 22 May 2021 20:09:54 -0700 |
| |
On 5/17/21 12:11 AM, Ingo Molnar wrote: > > * Randy Dunlap <rdunlap@infradead.org> wrote: > >> Both arch/um/ and arch/xtensa/ cause a Kconfig warning for LOCKDEP. >> These arch-es select LOCKDEP_SUPPORT but they are not listed as one >> of the arch-es that LOCKDEP depends on. >> >> Since (16) arch-es define the Kconfig symbol LOCKDEP_SUPPORT if they >> intend to have LOCKDEP support, replace the awkward list of >> arch-es that LOCKDEP depends on with the LOCKDEP_SUPPORT symbol. >> >> Fixes this kconfig warning: (for both um and xtensa) >> >> WARNING: unmet direct dependencies detected for LOCKDEP >> Depends on [n]: DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] && (FRAME_POINTER [=n] || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86) >> Selected by [y]: >> - PROVE_LOCKING [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] >> - LOCK_STAT [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] >> - DEBUG_LOCK_ALLOC [=y] && DEBUG_KERNEL [=y] && LOCK_DEBUGGING_SUPPORT [=y] >> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Peter Zijlstra <peterz@infradead.org> >> Cc: Ingo Molnar <mingo@redhat.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Waiman Long <longman@redhat.com> >> Cc: Boqun Feng <boqun.feng@gmail.com> >> Cc: Chris Zankel <chris@zankel.net> >> Cc: Max Filippov <jcmvbkbc@gmail.com> >> Cc: linux-xtensa@linux-xtensa.org >> Cc: Johannes Berg <johannes@sipsolutions.net> >> Cc: Jeff Dike <jdike@addtoit.com> >> Cc: Richard Weinberger <richard@nod.at> >> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> >> Cc: linux-um@lists.infradead.org >> --- >> lib/Kconfig.debug | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20210514.orig/lib/Kconfig.debug >> +++ linux-next-20210514/lib/Kconfig.debug >> @@ -1383,7 +1383,7 @@ config LOCKDEP >> bool >> depends on DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT >> select STACKTRACE >> - depends on FRAME_POINTER || MIPS || PPC || S390 || MICROBLAZE || ARM || ARC || X86 >> + depends on FRAME_POINTER || LOCKDEP_SUPPORT > > Ok - the FRAME_POINTER bit is weird. Are there any architectures that have > FRAME_POINTER defined but no LOCKDEP_SUPPORT?
arch/h8300/ does AFAICT. and arch/parisc/ has user-choosable FRAME_POINTER and no LOCKDEP support.
-- ~Randy
|  |