lkml.org 
[lkml]   [2021]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/5] fpga: generalize updating the card
Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.13-rc2 next-20210521]
[cannot apply to xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/trix-redhat-com/generalize-fpga_mgr_load/20210522-224247
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd860052c99b1e088352bdd4fb7aef46f8d2ef47
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/808aa2625c17a6d7c5a81e9c3e45d122a5e32f0a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review trix-redhat-com/generalize-fpga_mgr_load/20210522-224247
git checkout 808aa2625c17a6d7c5a81e9c3e45d122a5e32f0a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/fpga/stratix10-soc.c:398:3: error: 'const struct fpga_manager_ops' has no member named 'partial_reconfig'
398 | .partial_reconfig.write_init = s10_ops_write_init,
| ^~~~~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:398:37: error: initialization of 'u64 (*)(struct fpga_manager *)' {aka 'long long unsigned int (*)(struct fpga_manager *)'} from incompatible pointer type 'int (*)(struct fpga_manager *, struct fpga_image_info *, const char *, size_t)' {aka 'int (*)(struct fpga_manager *, struct fpga_image_info *, const char *, long unsigned int)'} [-Werror=incompatible-pointer-types]
398 | .partial_reconfig.write_init = s10_ops_write_init,
| ^~~~~~~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:398:37: note: (near initialization for 's10_ops.status')
drivers/fpga/stratix10-soc.c:399:3: error: 'const struct fpga_manager_ops' has no member named 'partial_reconfig'
399 | .partial_reconfig.write = s10_ops_write,
| ^~~~~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:399:37: error: invalid initializer
399 | .partial_reconfig.write = s10_ops_write,
| ^~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:399:37: note: (near initialization for 's10_ops.reconfig.<anonymous>')
drivers/fpga/stratix10-soc.c:400:3: error: 'const struct fpga_manager_ops' has no member named 'partial_reconfig'
400 | .partial_reconfig.write_complete = s10_ops_write_complete,
| ^~~~~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:400:37: error: invalid initializer
400 | .partial_reconfig.write_complete = s10_ops_write_complete,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/fpga/stratix10-soc.c:400:37: note: (near initialization for 's10_ops.reimage.<anonymous>')
>> drivers/fpga/stratix10-soc.c:396:48: warning: missing braces around initializer [-Wmissing-braces]
396 | static const struct fpga_manager_ops s10_ops = {
| ^
......
399 | .partial_reconfig.write = s10_ops_write,
| { }
400 | .partial_reconfig.write_complete = s10_ops_write_complete,
| {
401 | };
| }
cc1: some warnings being treated as errors


vim +396 drivers/fpga/stratix10-soc.c

e7eef1d7633a87 Alan Tull 2018-11-13 395
e7eef1d7633a87 Alan Tull 2018-11-13 @396 static const struct fpga_manager_ops s10_ops = {
e7eef1d7633a87 Alan Tull 2018-11-13 397 .state = s10_ops_state,
808aa2625c17a6 Tom Rix 2021-05-20 398 .partial_reconfig.write_init = s10_ops_write_init,
808aa2625c17a6 Tom Rix 2021-05-20 399 .partial_reconfig.write = s10_ops_write,
808aa2625c17a6 Tom Rix 2021-05-20 400 .partial_reconfig.write_complete = s10_ops_write_complete,
e7eef1d7633a87 Alan Tull 2018-11-13 401 };
e7eef1d7633a87 Alan Tull 2018-11-13 402

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-05-22 23:00    [W:0.050 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site