[lkml]   [2021]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7,2/4] PKCS#7: Check codeSigning EKU for kernel module and kexec pe verification
Hi Chun-Yi",

I love your patch! Perhaps something to improve:

[auto build test WARNING on cryptodev/master]
[also build test WARNING on linus/master v5.13-rc2 next-20210521]
[cannot apply to crypto/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: master
config: openrisc-randconfig-r015-20210522 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Lee-Chun-Yi/Check-codeSigning-extended-key-usage-extension/20210522-220349
git checkout 928555596c9cd62caabf8777ed8152ddac2609ef
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <>

All warnings (new ones prefixed by >>):

In file included from certs/system_keyring.c:17:
include/keys/system_keyring.h:72:1: error: expected identifier or '(' before '{' token
72 | {
| ^
>> include/keys/system_keyring.h:70:19: warning: 'is_key_on_revocation_list' used but never defined
70 | static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
| ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/is_key_on_revocation_list +70 include/keys/system_keyring.h

62 extern int add_key_to_revocation_list(const char *data, size_t size);
63 extern int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
64 enum key_being_used_for usage);
65 #else
66 static inline int add_key_to_revocation_list(const char *data, size_t size)
67 {
68 return 0;
69 }
> 70 static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7,
71 enum key_being_used_for usage);
72 {
73 return -ENOKEY;
74 }
75 #endif

0-DAY CI Kernel Test Service, Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2021-05-22 20:56    [W:0.094 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site