Messages in this thread |  | | From | Linus Walleij <> | Date | Sat, 22 May 2021 12:34:28 +0200 | Subject | Re: [PATCH v7 04/10] drm: Introduce the DP AUX bus |
| |
On Mon, May 17, 2021 at 10:09 PM Douglas Anderson <dianders@chromium.org> wrote:
> Historically "simple" eDP panels have been handled by panel-simple > which is a basic platform_device. In the device tree, the panel node > was at the top level and not connected to anything else. > > Let's change it so that, instead, panels can be represented as being > children of the "DP AUX bus". Essentially we're saying that the > hierarchy that we're going to represent is the "control" connections > between devices. The DP AUX bus is a control bus provided by an eDP > controller (the parent) and consumed by a device like a panel (the > child). > > The primary incentive here is to cleanly provide the panel driver the > ability to communicate over the AUX bus while handling lifetime issues > properly. The panel driver may want the AUX bus for controlling the > backlight or querying the panel's EDID. > > The idea for this bus's design was hashed out over IRC [1]. > > [1] https://people.freedesktop.org/~cbrill/dri-log/?channel=dri-devel&date=2021-05-11 > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Lyude Paul <lyude@redhat.com> > Cc: Rajeev Nandan <rajeevny@codeaurora.org> > Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
I like the concept and the general idea behind this, clean and helpful design. Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
|  |