lkml.org 
[lkml]   [2021]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 0/5] misc/pvpanic: Fix some errro handling path and simplify code
On Sat, May 22, 2021 at 9:54 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> This serie was previously sent in 2 parts, one for -pci.c and one for
> -mmio.c.
> Execpt the patch 5/5 which is new, the 4 first patches are the same as the
> ones previously posted. Only the description has been slighly updated.
>
> Pacth 5/5 is a proposal to simplify code and turn 'pvpanic_probe()' into a
> fully resource managed version.
> This way callers don't need to do some clean-up on error in the
> probe and on remove.
>
>
> "Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>" was only
> added on patch 1 and 3. I was unsure if his Reviewed-by was also related to
> the s/GFP_ATOMIC/GFP_KERNEL/ of patch 2 et 4.

To be sure, always send a series with a cover letter :-)
Yes, 2 and 4 were also included.

> Christophe JAILLET (5):
> misc/pvpanic-pci: Fix error handling in 'pvpanic_pci_probe()'
> misc/pvpanic-pci: Use GFP_KERNEL instead of GFP_ATOMIC
> misc/pvpanic-mmio: Fix error handling in 'pvpanic_mmio_probe()'
> misc/pvpanic-mmio: Use GFP_KERNEL instead of GFP_ATOMIC
> misc/pvpanic: Make 'pvpanic_probe()' resource managed
>
> drivers/misc/pvpanic/pvpanic-mmio.c | 17 ++--------------
> drivers/misc/pvpanic/pvpanic-pci.c | 22 ++++-----------------
> drivers/misc/pvpanic/pvpanic.c | 30 ++++++++++++++---------------
> drivers/misc/pvpanic/pvpanic.h | 3 +--
> 4 files changed, 22 insertions(+), 50 deletions(-)
>
> --
> 2.30.2
>


--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-05-22 12:04    [W:0.115 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site