Messages in this thread | | | Date | Fri, 21 May 2021 14:18:13 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: rtl8712: Fix memory leak in r8712_init_recv_priv |
| |
On Fri, May 21, 2021 at 08:08:11PM +0800, Dongliang Mu wrote: > r871xu_dev_remove failed to call r8712_free_drv_sw() and free the > resource (e.g., struct urb) due to the failure of firmware loading. > > Fix this by invoking r8712_free_drv_sw at the failure site. > > Reported-by: syzbot+1c46f3771695bccbdb3a@syzkaller.appspotmail.com > Fixes: b4383c971bc5 ("staging: rtl8712: handle firmware load failure") > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> > --- > drivers/staging/rtl8712/usb_intf.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c > index dc21e7743349..a5190b4250ce 100644 > --- a/drivers/staging/rtl8712/usb_intf.c > +++ b/drivers/staging/rtl8712/usb_intf.c > @@ -589,7 +589,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf, > */ > static void r871xu_dev_remove(struct usb_interface *pusb_intf) > { > - struct net_device *pnetdev = usb_get_intfdata(pusb_intf); > + struct net_device *pnetdev, *newpnetdev = usb_get_intfdata(pusb_intf); > struct usb_device *udev = interface_to_usbdev(pusb_intf); > > if (pnetdev) {
Did you test this?
I think you just broke the code right here :(
thanks,
greg k-h
| |