Messages in this thread | | | Date | Fri, 21 May 2021 14:41:28 +0300 | From | Pavel Skripkin <> | Subject | Re: [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers |
| |
On Fri, 21 May 2021 16:26:54 +0530 Aviral Gupta <shiv14112001@gmail.com> wrote:
> ERROR: switch and case should be at the same indent > + switch (whence) { > + case 1: > [...] > + case 0: > [...] > + default: > ERROR: code indent should use tabs where possible > + void (*callback)(struct dentry *))$ > > Signed-off-by: Aviral Gupta <shiv14112001@gmail.com> > --- > fs/libfs.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >
Hi, Aviral!
Always check your patches with ./scripts/checpatch.pl. It will warn You if your patch has common errors (ex: too long subject line like yours).
I think, this link might be helpful https://www.kernel.org/doc/html/latest/process/submitting-patches.html. This document contains canonical patch format and other useful info about "how to send patches".
Goog luck!
With regards, Pavel Skripkin
| |