Messages in this thread | | | Date | Fri, 21 May 2021 12:23:38 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH 0/4] MIPS: ralink: pci: driver for Pcie controller in MT7621 SoCs |
| |
On Wed, May 19, 2021 at 11:18:36PM +0200, Sergio Paracuellos wrote: > On Wed, May 19, 2021 at 10:36 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > But most of the similar drivers are in drivers/pci/controller/, where > > I think it's easier to keep them up to date with changes in the PCI > > core. Have you considered putting this one there? > > Most pci drivers in 'arch/mips/pci' are still using PCI_LEGACY stuff. > In contrast mt7621-pci is using current pci generic apis but even most > of the code is generic enough, there is one remaining thing which > depends on mips architecture which is the iocu region configuration > which must be done in the driver itself. This is the only reason to > move this driver into 'arch/mips/pci' instead of > 'drivers/pci/controller/'. So... I am all ears to listen to > suggestions for the proper place for this driver. Thomas, do you have > any thoughts on this?
I tried to put a pci-xtalk driver into drivers/pci/controller, but Lorenzo didn't want it there for being MIPS and not DT based. So this one is DT based, but still MIPS. I'm perfectly fine putting this driver into drivers/pci/controller/
Lorenzo, what's your opinion ?
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |