lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] serial: rp2: disable interrupt in rp2_probe():
On Thu, May 20, 2021 at 10:30 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, May 14, 2021 at 11:17:07AM +0000, Zheyu Ma wrote:
> > In 'rp2_probe', the driver registers 'rp2_uart_interrupt' then calls
> > 'rp2_fw_cb' through 'request_firmware_nowait'. In 'rp2_fw_cb', if the
> > firmware don't exists, function just return without initializing ports
> > of 'rp2_card'. But now the interrupt handler function has been registered,
> > and when an interrupt comes('rp2' may shares an interrupt line with other
> > devices), 'rp2_uart_interrupt' may access those ports then causing NULL
> > pointer dereference or other bugs.
> >
> > Fix this by disabling interrupt after registering 'rp2_uart_interrupt',
> > and enable it in 'rp2_uart_startup'.
>
> What prevents an interrupt from coming in right after callin
> rp2_uart_interrupt()? The driver has to be able to handle that. Why is
> the interrupt being registered before the firmware is loaded? That
> should be the proper fix as once you register an interrupt, the driver
> HAS to be able to properly handle it.
>
> thanks,
>
> greg k-h

Thanks for your comments, I will reconsider this patch and send the
second version of the patch.

Zheyu Ma

\
 
 \ /
  Last update: 2021-05-21 07:10    [W:0.038 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site