lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] gpio: gpio-da9055: remove platform_set_drvdata() + cleanup probe
Date
On 14 May 2021 10:24, Alexandru Ardelean wrote:

> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>

Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
> drivers/gpio/gpio-da9055.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-da9055.c b/drivers/gpio/gpio-da9055.c
> index 6ad0c37b862e..49446a030f10 100644
> --- a/drivers/gpio/gpio-da9055.c
> +++ b/drivers/gpio/gpio-da9055.c
> @@ -133,7 +133,6 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
> {
> struct da9055_gpio *gpio;
> struct da9055_pdata *pdata;
> - int ret;
>
> gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL);
> if (!gpio)
> @@ -146,15 +145,7 @@ static int da9055_gpio_probe(struct platform_device
> *pdev)
> if (pdata && pdata->gpio_base)
> gpio->gp.base = pdata->gpio_base;
>
> - ret = devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, gpio);
> -
> - return 0;
> + return devm_gpiochip_add_data(&pdev->dev, &gpio->gp, gpio);
> }
>
> static struct platform_driver da9055_gpio_driver = {
> --
> 2.31.1

\
 
 \ /
  Last update: 2021-05-21 10:46    [W:0.133 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site