lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] dt-bindings: gpio: gpio-davinci: Convert to json-schema
From
Date
Hi Aswath, Rob,

On 21/05/2021 10:51, Aswath Govindraju wrote:
> Convert gpio-davinci dt-binding documentation from txt to yaml format.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
>
> changes since v1:
> - combined the individual compatible properties into one enum
> - added maxItems and minItems properties for gpio-line-names and
> interrupts
> - updated the description of interrupts property
> - removed the description for properties that are general
> - updated the pattern property for gpio hog to indicate any sort
> node name based on its usage
> - corrected the example wakeup gpio node name
>
> .../devicetree/bindings/gpio/gpio-davinci.txt | 167 ---------------
> .../bindings/gpio/gpio-davinci.yaml | 196 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 197 insertions(+), 168 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> deleted file mode 100644
> index 696ea46227d1..000000000000
> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt
> +++ /dev/null
> @@ -1,167 +0,0 @@
> -Davinci/Keystone GPIO controller bindings
> -
> -Required Properties:
> -- compatible: should be "ti,dm6441-gpio": for Davinci da850 SoCs
> - "ti,keystone-gpio": for Keystone 2 66AK2H/K, 66AK2L,
> - 66AK2E SoCs
> - "ti,k2g-gpio", "ti,keystone-gpio": for 66AK2G
> - "ti,am654-gpio", "ti,keystone-gpio": for TI K3 AM654
> - "ti,j721e-gpio", "ti,keystone-gpio": for J721E SoCs
> - "ti,am64-gpio", "ti,keystone-gpio": for AM64 SoCs

[...]

> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> new file mode 100644
> index 000000000000..28b924997be5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> @@ -0,0 +1,196 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/gpio-davinci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO controller for Davinci and keystone devices
> +
> +maintainers:
> + - Keerthy <j-keerthy@ti.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - ti,k2g-gpio
> + - ti,am654-gpio
> + - ti,j721e-gpio
> + - ti,am64-gpio
> + - const: ti,keystone-gpio
> +
> + - items:
> + - enum:
> + - ti,dm6441-gpio
> + - ti,keystone-gpio
> +
> + reg:
> + maxItems: 1
> +
> + gpio-controller: true
> +
> + gpio-ranges: true
> +
> + gpio-line-names:
> + description: strings describing the names of each gpio line.
> + minItems: 1
> + maxItems: 100
> +
> + "#gpio-cells":
> + const: 2
> + description:
> + first cell is the pin number and second cell is used to specify optional parameters (unused).
> +
> + interrupts:
> + description:
> + The interrupts are specified as per the interrupt parent. Only banked
> + or unbanked IRQs are supported at a time. If the interrupts are
> + banked then provide list of interrupts corresponding to each bank, else
> + provide the list of interrupts for each gpio.
> + minItems: 1
> + maxItems: 100
> +
> + ti,ngpio:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: The number of GPIO pins supported consecutively.
> + minimum: 1
> +
> + ti,davinci-gpio-unbanked:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: The number of GPIOs that have an individual interrupt line to processor.
> + minimum: 0
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: gpio
> +
> + interrupt-controller: true
> +
> + power-domains:
> + maxItems: 1
> +
> + "#interrupt-cells":
> + const: 2
> +
> +patternProperties:
> + "^.*$":
> + if:
> + type: object
> + then:
> + properties:
> + gpios: true
> + gpio-hog: true
> + input: true
> + output-high: true
> + output-low: true
> + line-name: true
> +
> + required:
> + - gpio-hog
> + - gpios

Missed v2 - copy pasting here also:

I see that gpio-hog.yaml dtschema has been added.
Can it be reused here and how?

[...]

--
Best regards,
grygorii

\
 
 \ /
  Last update: 2021-05-21 10:35    [W:0.316 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site