Messages in this thread | | | Date | Fri, 21 May 2021 10:11:30 +0200 | From | Stephan Gerhold <> | Subject | Re: [PATCH v3 03/17] dt-bindings: qcom-bam: Add 'iommus' to required properties |
| |
Hi,
On Wed, May 19, 2021 at 08:06:46PM +0530, Bhupesh Sharma wrote: > Add the missing required property - 'iommus' to the > device-tree binding documentation for qcom-bam DMA IP. > > This property describes the phandle(s) to apps_smmu node with sid mask. > > Cc: Thara Gopinath <thara.gopinath@linaro.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Andy Gross <agross@kernel.org> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: David S. Miller <davem@davemloft.net> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Vinod Koul <vkoul@kernel.org> > Cc: dmaengine@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Cc: linux-crypto@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: bhupesh.linux@gmail.com > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > .../devicetree/bindings/dma/qcom_bam_dma.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > index d2900616006c..2479862a3654 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > @@ -55,6 +55,12 @@ properties: > interconnect-names: > const: memory > > + iommus: > + minItems: 1 > + maxItems: 8 > + description: | > + phandle to apps_smmu node with sid mask. > + > qcom,ee: > $ref: /schemas/types.yaml#/definitions/uint8 > description: > @@ -81,6 +87,7 @@ required: > - clocks > - clock-names > - "#dma-cells" > + - iommus
I don't think we can make this required, older SoCs don't use "iommus" for bam_dma.
arch/arm64/boot/dts/qcom/apq8016-sbc.dt.yaml: dma-controller@7884000: 'iommus' is a required property From schema: Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml
Stephan
| |