Messages in this thread | | | Subject | Re: [PATCH 1/3] crypto: ecdh - fix 'ecdh_init' | From | Hui Tang <> | Date | Fri, 21 May 2021 16:08:10 +0800 |
| |
On 2021/5/21 15:45, Herbert Xu wrote: > On Wed, May 12, 2021 at 02:40:00PM +0800, Hui Tang wrote: >> NIST P192 is not unregistered if failed to register NIST P256, >> actually it need to unregister the algorithms already registered. >> >> Signed-off-by: Hui Tang <tanghui20@huawei.com> >> --- >> crypto/ecdh.c | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) > > Thanks for catching this. The variable ecdh_nist_p192_registered > is bogus. You should just make it so that if p192 fails to > register then the init function aborts. There would then be > no need to check for the registered state in the exit function. >
Okay, I will fix it in next version, and 'ecdsa_init' should do the same thing too?
>
| |