lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 2/3] pinctrl: core: configure pinmux from pins debug file
    From
    Date
    Hello Dario,

    On 5/20/21 11:27 PM, Dario Binacchi wrote:
    > The MPUs of some architectures (e.g AM335x) must be in privileged
    > operating mode to write on the pinmux registers. In such cases, where
    > writes will not work from user space, now it can be done from the pins

    user space has no connection to the problem you're trying to solve.

    Please provide a reasonable rationale for adding a new interface, thank
    you in advance.

    > debug file if the platform driver exports the pin_dbg_set() helper among
    > the registered operations.
    >
    > Signed-off-by: Dario Binacchi <dariobin@libero.it>

    I strongly object against this new interface.

    As Andy've already mentioned you have to operate with defined pin groups
    and functions, and so far you create an interface with an option to
    disasterous misusage, it shall be avoided, because there are better
    options.

    What's the issue with a regular declaration of pin groups and functions
    on your SoC? When it's done, you can operate on this level of abstraction,
    there is absolutely no need to add the proposed low-level debug interface.

    --
    Best wishes,
    Vladimir

    \
     
     \ /
      Last update: 2021-05-21 08:45    [W:2.957 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site