lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH V2 08/18] i2c: imx-lpi2c: add debug message when i2c peripheral clk doesn't work
    Date
    > From: Clark Wang <xiaoning.wang@nxp.com>
    > Sent: Tuesday, April 6, 2021 7:33 PM
    >
    > add debug message when i2c peripheral clk rate is 0, then directly return
    > -EINVAL.
    >
    > Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>

    You sign-off should be put after the original patch author

    > Signed-off-by: Gao Pan <pandy.gao@nxp.com>
    > Reviewed-by: Andy Duan <fugang.duan@nxp.com>

    Drop the original review when they're significant changes

    > ---
    > V2 changes:
    > - Add my signed-off.
    > ---
    > drivers/i2c/busses/i2c-imx-lpi2c.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c
    > b/drivers/i2c/busses/i2c-imx-lpi2c.c
    > index 333209ba81c1..dfec334712c2 100644
    > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c
    > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
    > @@ -210,6 +210,11 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct
    > *lpi2c_imx)
    > lpi2c_imx_set_mode(lpi2c_imx);
    >
    > clk_rate = clk_get_rate(lpi2c_imx->clk_per);
    > + if (!clk_rate) {
    > + dev_dbg(&lpi2c_imx->adapter.dev, "clk_per rate is 0\n");

    s/dev_dbg/dev_err

    > + return -EINVAL;
    > + }
    > +
    > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST)
    > filt = 0;
    > else
    > --
    > 2.25.1

    \
     
     \ /
      Last update: 2021-05-21 08:45    [W:4.467 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site