Messages in this thread | | | Date | Fri, 21 May 2021 22:16:44 +0200 | From | Ralf Schlatterbeck <> | Subject | Re: [PATCH 1/1] spi-sun6i: Fix chipselect/clock bug |
| |
On Fri, May 21, 2021 at 05:30:11PM +0100, Andre Przywara wrote: > On Thu, 20 May 2021 12:06:56 +0200 > Ralf Schlatterbeck <rsc@runtux.com> wrote: > So if I get your last email correctly, your intention was to make this > Mirko's patch, which you just send?
Yes.
> In this case the authorship should stay with him (git commit --amend > --author "..."), and you add your S-o-b (his first, your's next). > If you use git format-patch & git send-email, it will take care of > formatting this correctly (inserting a "From" line into the body).
I was using format-patch but editing the result. Would a 'Date' line in the body also be OK? The patch is really from 2019...
I have it correctly in my git but was unaware that additional header lines in the body are ok.
> One formatting thing below: > > sun6i_spi_write(sspi, SUN6I_CLK_CTL_REG, reg); > > + /* Finally enable the bus - doing so before might raise SCK to HIGH */ > > + sun6i_spi_write(sspi, SUN6I_GBL_CTL_REG, > > + sun6i_spi_read(sspi, SUN6I_GBL_CTL_REG) > > + | SUN6I_GBL_CTL_BUS_ENABLE); > > The "|" on the new line looks a bit odd. What about you utilise "reg" > here, as the other access do, to make this more readable? > reg = sun6i_spi_read(...); > reg |= ... > sun6i_spi_write(..., reg);
I've fixed this and will resubmit.
Thanks, Ralf
| |