Messages in this thread | | | Date | Fri, 21 May 2021 20:44:43 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] b43: don't save dentries for debugfs |
| |
On Tue, May 18, 2021 at 08:47:58PM +0300, Kalle Valo wrote: > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > > There is no need to keep around the dentry pointers for the debugfs > > files as they will all be automatically removed when the subdir is > > removed. So save the space and logic involved in keeping them around by > > just getting rid of them entirely. > > > > By doing this change, we remove one of the last in-kernel user that was > > storing the result of debugfs_create_bool(), so that api can be cleaned > > up. > > > > Cc: Kalle Valo <kvalo@codeaurora.org> > > Cc: "David S. Miller" <davem@davemloft.net> > > Cc: Jakub Kicinski <kuba@kernel.org> > > Cc: Kees Cook <keescook@chromium.org> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Cc: Jason Gunthorpe <jgg@ziepe.ca> > > Cc: Chao Yu <chao@kernel.org> > > Cc: Leon Romanovsky <leon@kernel.org> > > Cc: linux-wireless@vger.kernel.org > > Cc: b43-dev@lists.infradead.org > > Cc: netdev@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/net/wireless/broadcom/b43/debugfs.c | 34 +++------------------ > > drivers/net/wireless/broadcom/b43/debugfs.h | 3 -- > > 2 files changed, 5 insertions(+), 32 deletions(-) > > > > Note, I can take this through my debugfs tree if wanted, that way I can > > clean up the debugfs_create_bool() api at the same time. Otherwise it's > > fine, I can wait until next -rc1 for that to happen. > > Yeah, it's best that you take this via your tree. > > Acked-by: Kalle Valo <kvalo@codeaurora.org>
Thanks, will do!
greg k-h
| |