lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 253/425] ALSA: core: remove redundant spin_lock pair in snd_card_disconnect
    Date
    From: Jia Zhou <zhou.jia2@zte.com.cn>

    [ Upstream commit abc21649b3e5c34b143bf86f0c78e33d5815e250 ]

    modification in commit 2a3f7221acdd ("ALSA: core: Fix card races between
    register and disconnect") resulting in this problem.

    Fixes: 2a3f7221acdd ("ALSA: core: Fix card races between register and disconnect")
    Signed-off-by: Jia Zhou <zhou.jia2@zte.com.cn>
    Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
    Link: https://lore.kernel.org/r/1616989007-34429-1-git-send-email-wang.yi59@zte.com.cn
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/core/init.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/sound/core/init.c b/sound/core/init.c
    index 16b7cc7aa66b..3eafa15006f8 100644
    --- a/sound/core/init.c
    +++ b/sound/core/init.c
    @@ -405,10 +405,8 @@ int snd_card_disconnect(struct snd_card *card)
    return 0;
    }
    card->shutdown = 1;
    - spin_unlock(&card->files_lock);

    /* replace file->f_op with special dummy operations */
    - spin_lock(&card->files_lock);
    list_for_each_entry(mfile, &card->files_list, list) {
    /* it's critical part, use endless loop */
    /* we have no room to fail */
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-05-20 12:31    [W:4.393 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site